Messages in this thread | | | Subject | Re: PATCH: clean up the IDE iops, add ones for a dead iface | From | Benjamin Herrenschmidt <> | Date | 19 Feb 2003 18:26:35 +0100 |
| |
On Wed, 2003-02-19 at 19:22, Alan Cox wrote: > On Wed, 2003-02-19 at 17:06, Benjamin Herrenschmidt wrote: > > Yup, you are right. Removing a disk from a controller shall return > > anything with bit 7 at 0 per spec, but removing the controller > > itself will return 0xff. Actually, in my "wait for BSY low" loop > > I added to the probe code for pmac (should be made generic sooner > > or later), I did special case 0xff. > > > > So we should indeed fix the various bits in IDE. 0xff out of > > status, I beleive, never means anything and can always be considered > > as "this interface is gone". > > I think thats the wrong approach too. We need to be defensive on things > like IDE probes. We just have to be sure that we -do- eventually say > 'its bust', and when we know from hotplug a channel has vanished also > be sure to check the 'its dead jim' flag once I add it
Ok, then let's make sure we have no endless loops caused by BSY returning 1 and _not_ checking the "dead" flag. I'm sure I can find some of these in a couple of places (like when setting the PIO/DMA mode).
Ben. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |