lkml.org 
[lkml]   [2003]   [Feb]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: PATCH: clean up the IDE iops, add ones for a dead iface
From
Date
On Wed, 2003-02-19 at 17:06, Benjamin Herrenschmidt wrote:
> Yup, you are right. Removing a disk from a controller shall return
> anything with bit 7 at 0 per spec, but removing the controller
> itself will return 0xff. Actually, in my "wait for BSY low" loop
> I added to the probe code for pmac (should be made generic sooner
> or later), I did special case 0xff.
>
> So we should indeed fix the various bits in IDE. 0xff out of
> status, I beleive, never means anything and can always be considered
> as "this interface is gone".

I think thats the wrong approach too. We need to be defensive on things
like IDE probes. We just have to be sure that we -do- eventually say
'its bust', and when we know from hotplug a channel has vanished also
be sure to check the 'its dead jim' flag once I add it

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 13:33    [W:0.058 / U:3.688 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site