lkml.org 
[lkml]   [2003]   [Feb]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCHSET] PC-9800 subarch. support for 2.5.61 (2/26) APM
On Mon, Feb 17, 2003 at 10:49:55PM +0900, Osamu Tomita wrote:
> +#include "io_ports.h"

Isn't this introduced in a later patch? Please make sure your patchkit
never breaks the compile of the existing subarches when applied in order.

> "pushl %%edi\n\t"
> "pushl %%ebp\n\t"
> +#ifdef CONFIG_X86_PC9800
> + "pushfl\n\t"
> +#endif
> "lcall *%%cs:apm_bios_entry\n\t"
> "setc %%al\n\t"
> "popl %%ebp\n\t"
> @@ -682,6 +687,9 @@
> __asm__ __volatile__(APM_DO_ZERO_SEGS
> "pushl %%edi\n\t"
> "pushl %%ebp\n\t"
> +#ifdef CONFIG_X86_PC9800
> + "pushfl\n\t"
> +#endif

Maybe add a

#ifdef CONFIG_X86_PC9800
#define COND_PUSHFL "pushfl\n\t"
#else
#define COND_PUSHFL "pushfl\n\t"
#endif

to the top of this file and then use it?

> +#ifndef CONFIG_X86_PC9800

Once again please always use #ifdef instead of #ifndef where possible.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 13:33    [W:0.128 / U:0.696 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site