lkml.org 
[lkml]   [2003]   [Feb]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH][2.5] convert atm_dev_lock from spinlock to semaphore
From
Date
On Tue, 2003-02-18 at 18:53, Matthew Wilcox wrote:
> you seem to be under the impression that <linux/sem.h> has something
> to do with linux semaphores. this is not the case; they're sysv semaphores.

I agree, this bit has to be fixed.

> atm really needs fixing properly.

True, but his change by itself is OK. All of the places where
atm_dev_lock is acquired it is safe to do things like sleep.

While checking this I notice that atm_alloc_dev uses GFP_ATOMIC
thus unnecessarily.

Anyways, Matt, without a full time ATM maintainer and having basically
nobody who wants to take that on, we should take the small fixes when
they do occur and are correct as Chas's patch is.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 13:33    [W:0.039 / U:3.068 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site