lkml.org 
[lkml]   [2003]   [Feb]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [RFC] Migrating net/sched to new module interface
Hi,

On Mon, 17 Feb 2003, Rusty Russell wrote:

> There were two major changes in the module code. The first was to
> simplify the userland interface, from:
>
> sys_create_module(name, size)
> sys_query_module(...) (a 5-way multiplexed syscall)
> sys_init_module(name, ptr)
>
> to:
> sys_init_module(ptr, len, userargs)
>
> To argue against this change is a demonstration of lack of
> understanding, or a complete lack of taste.

Maybe you could share a bit of your wisdom?
1. Doing the linking in userspace requires two steps, but I still don't
know what's so bad about it.
2. This still doesn't explain, why everything has to be moved into kernel,
why can't we move more into userspace?
3. You simply moved part of the query syscall functionality to
/proc/modules (which btw is still not enough to fix ksymoops).

> The second change was the speed up one system of module locking in the
> kernel which wasn't racy, and deprecate the other system which was
> racy in 99% of its uses. That is all.

Well, I'm not against optimizing the module locking (*), as we won't get
rid of it in the near feature, but it still has problems.
1. It's adding complexity (however you implement it), I explained it in
detail and you still haven't told me, where I'm wrong.
2. The module interface is incompatible with other kernel interfaces, I
tried to explain that in the mail from saturday, if you think I'm wrong,
your input is very welcome, but _please_ answer to that mail.

> Did it solve all the races in the kernel? Of course not. But it's
> simple to use, already well understood in the kernel, and avoids
> massive changes. It also allows connection tracking to be properly
> modularized, which was my long-lost original purpose.

It's too much fun to quote Al here:
"And no, I don't buy arguments about poor interface-writers. You do some
infrastructure intended to be used by driver-writers - you are supposed
to have a clue. 'Cause having rabid monkeys on crack on *both* sides of
an interface is a recipe for disaster and on the driver side you are
guaranteed to have a bunch of them.

We need to have interfaces cleaned up. No silver bullets there. There's
maybe a dozen of interfaces that cover 99% of all drivers out there. Remaining
1% can and should fend for itself - you do something really tricky, you
are responsible for getting it right."

> I've repeated this enough now, I think.

Yes, you repeated your "executive summaries" now often enough, maybe you
can impress some manager with it, but it's highly offensive to kernel
hackers. Could you _please_ come up with some arguments now?

bye, Roman

(*) BTW I have patch that would make the unload path usable again, it
would only be required to add a single smp_mb() to the fast path.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 13:33    [W:0.150 / U:3.916 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site