lkml.org 
[lkml]   [2003]   [Feb]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH][2.5][8/14] smp_call_function_on_cpu - s390
Date
Zwane Mwaikambo wrote:

> On Sat, 15 Feb 2003, Ulrich Weigand wrote:
> > That's still '&&' instead of '&'.
>
> *sigh*

Hmm. I think this code still has a problem. If the caller
passes in a mask containing bits for offline CPUs, those will
be counted here

> + num_cpus = hweight32(mask);

but there will be no external interrupt generated for those,
and thus this loop

> + while (atomic_read(&data.started) != num_cpus)

will never terminate ...


Bye,
Ulrich

--
Dr. Ulrich Weigand
weigand@informatik.uni-erlangen.de
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 13:33    [W:0.035 / U:0.972 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site