Messages in this thread | | | Date | Sat, 15 Feb 2003 10:04:24 +0000 | From | Russell King <> | Subject | Re: [PATCH 2.5.60 5/9] Update the Archimedes parallel port driver for new module API. |
| |
On Fri, Feb 14, 2003 at 04:37:00PM -0800, Bob Miller wrote: > -static void arc_inc_use_count(void) > +static int arc_inc_use_count(void) > { > -#ifdef MODULE > - MOD_INC_USE_COUNT; > -#endif > + return try_module_get(THIS_MODULE); > }
Isn't one of the points of the module system that we don't try to run code inside a module without the module being reference counted?
The normal way this is done is to add the module structure pointer into a structure, and run try_module_get() from code external to the module in question. The above method would seem to violate that.
Rusty - comments?
-- Russell King (rmk@arm.linux.org.uk) The developer of ARM Linux http://www.arm.linux.org.uk/personal/aboutme.html
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |