Messages in this thread | | | Date | Fri, 14 Feb 2003 04:48:18 -0500 | From | Olivier Galibert <> | Subject | Re: [BUG] smctr.c changes in latest BK |
| |
On Fri, Feb 14, 2003 at 12:05:24AM +0100, Jochen Friedrich wrote: > On Thu, 13 Feb 2003, Jochen Friedrich wrote: > > Please revert this one as it is just wrong. As already mentioned here in > > LKML (IIRC it was Alan), the semicolon is really intended here. > > > > The above loop just runs until a non-zero byte is found in the MAC > > address or all 6 bytes have been checked. A value of i=6 will then > > indicate an all-zero MAC address. > > After taking a second look, i just recognized that both cases (MAC adress > all-zero or not) are handled exactly the same (by duplicated code), so the > whole stuff is unnecessary. > > The whole function just reduces to a simple copy loop:
Doesn't that mean that the original function was buggy and it should not have copied the mac address over if one was user-provided?
OG. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |