Messages in this thread | | | Date | Fri, 14 Feb 2003 10:08:04 +0100 (MET) | From | "Maciej W. Rozycki" <> | Subject | Re: Switch APIC (+nmi, +oprofile) to driver model |
| |
On Thu, 13 Feb 2003, Mikael Pettersson wrote:
> +static int __init init_local_apic_devicefs(void) > { > - if (apic_pm_state.active) > - pm_register(PM_SYS_DEV, 0, apic_pm_callback); > + if (!cpu_has_apic)
This looks broken -- what if an external local APIC is present?
> + return 0; > + if (!apic_pm_state.active) { > + local_apic_driver.resume = NULL; > + local_apic_driver.suspend = NULL; > + } > + driver_register(&local_apic_driver); > + return sys_device_register(&device_local_apic); > }
-- + Maciej W. Rozycki, Technical University of Gdansk, Poland + +--------------------------------------------------------------+ + e-mail: macro@ds2.pg.gda.pl, PGP key available +
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |