lkml.org 
[lkml]   [2003]   [Feb]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH][2.5][8/14] smp_call_function_on_cpu - s390
Date
Zwane Mwaikambo wrote:

>+ cpu = get_cpu();
>+ mask &= (1UL << cpu);
>+ num_cpus = hweight32(mask);

I guess you mean
mask &= ~(1UL << cpu);
or else num_cpus is always either 0 or 1 ...

>+ for (i = 0; i < NR_CPUS; i++) {
>+ if (cpu_online(i) && ((1UL << cpu) && mask))

This should be
if (cpu_online(i) && ((1UL << i) & mask))
or else the message is sent to all online CPUs anyway ...

Bye,
Ulrich

--
Dr. Ulrich Weigand
weigand@informatik.uni-erlangen.de
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 13:33    [W:0.039 / U:9.288 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site