lkml.org 
[lkml]   [2003]   [Feb]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: 2.5.60 - drivers/char/esp.c vs include/linux/serialP.h
On Fri, Feb 14, 2003 at 03:39:34PM -0500, Valdis.Kletnieks@vt.edu wrote:
> compiling drivers/char/esp.c with -Wundef triggers a warning:
>
> In file included from drivers/char/esp.c:51:
> include/linux/serialP.h:27:6: warning: "LINUX_VERSION_CODE" is not defined
>
> The code that trips it up:
>
> #if (LINUX_VERSION_CODE < 0x020300)
> /* Unfortunate, but Linux 2.2 needs async_icount defined here and
> * it got moved in 2.3 */
> #include <linux/serial.h>
> #endif
>
> It's unclear if this should be fixed by adding a #include <linux/version.h>
> to esp.c, or if this code should summarily be lopped out of serialP.h.

My personal feeling woudl be to lop it out, and fix up anywhere
and everywhere which complains appropraitely.

--
Russell King (rmk@arm.linux.org.uk) The developer of ARM Linux
http://www.arm.linux.org.uk/personal/aboutme.html

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 13:33    [W:0.033 / U:5.292 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site