lkml.org 
[lkml]   [2003]   [Feb]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH][2.5][4/14] smp_call_function_on_cpu - MIPS
From
Date
On Fri, 2003-02-14 at 04:33, Zwane Mwaikambo wrote:
> +}
> +
> +int smp_call_function (void (*func) (void *info), void *info, int retry, int wait)
> +{
> + return smp_call_function_on_cpu(func, info, wait, cpu_online_map);
> }

IIRC, the semantics of smp_call_function() are to call the function on
all other cpus. So shouldn't this be

return smp_call_function_on_cpu(func, info, wait, cpu_online_map & ~(1<<smp_processor_id()));

?

Also, maybe you were planning to do this in a future patch, but
shouldn't smp_call_function() be moved to non-arch-specific code, given
this change?

-Justin


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 13:33    [W:0.063 / U:2.224 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site