lkml.org 
[lkml]   [2003]   [Feb]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRE: [PATCHSET] PC-9800 subarch. support for 2.5.60 (13/34) NIC
Date
Thanks for the comments.

-----Original Message-----
From: Christoph Hellwig
To: Osamu Tomita
Cc: Linux Kernel Mailing List; Alan Cox; Jeff Garzik
Sent: 2003/02/13 0:38
Subject: Re: [PATCHSET] PC-9800 subarch. support for 2.5.60 (13/34) NIC
>> +#ifdef CONFIG_X86_PC9800
>> +#undef __ISAPNP__
>> +#endif
>
> Don't do s.th. like that!
#if deined(__ISAPNP__) && !defined(CONFIG_X86_PC9800)
Each places are better?
PC98 has no EL3 PNP card, but has other PNP cards.

>> +#ifndef CONFIG_X86_PC9800
....
>> +#else
>> + id_port = 0x71d0;
>> +#endif

> use ifdef, not ifndef here
I see.

Regards,
Osamu Tomita
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 13:33    [from the cache]
©2003-2011 Jasper Spaans