Messages in this thread | | | Date | Wed, 12 Feb 2003 13:09:33 +0100 (CET) | From | Tim Schmielau <> | Subject | Re: [patch] jiffies wrap fixes for 2.5.60 |
| |
> > --- linux-2.5.60/arch/cris/drivers/usb-host.c Fri Jan 17 03:21:51 2003 > > +++ linux-2.5.60-jfix/arch/cris/drivers/usb-host.c Mon Feb 10 23:07:11 2003 > > @@ -459,7 +459,7 @@ > > *R_DMA_CH8_SUB2_CMD = IO_STATE(R_DMA_CH8_SUB2_CMD, cmd, stop); > > /* Somehow wait for the DMA to finish current activities */ > > i = jiffies + 100; > > - while (jiffies < i); > > + while (time_before(jiffies, i)); > > Busy wait? For several jiffies! Please... > I hope that interrupts are not disabled. > > > > --- linux-2.5.60/drivers/char/moxa.c Fri Jan 17 03:22:44 2003 > > +++ linux-2.5.60-jfix/drivers/char/moxa.c Mon Feb 10 23:01:59 2003
[...] > > But even worse useage is: > > void MoxaPortSendBreak(int port, int ms100) [...] > > And there are more uses like this...
I completely agree this is very bad practice. Still I prefer several miliseconds of busy-waiting to a potential 49 days busy wait.
Tim
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |