Messages in this thread | | | Date | Wed, 24 Dec 2003 10:30:16 -0800 | From | Andrew Morton <> | Subject | Re: [PATCH] clean up fs/devfs/base.c |
| |
Greg KH <greg@kroah.com> wrote: > > On Wed, Dec 24, 2003 at 12:00:13PM +0800, Ian Kent wrote: > > On Tue, 23 Dec 2003, Greg KH wrote: > > > > > On Tue, Dec 23, 2003 at 06:38:20PM -0800, Andrew Morton wrote: > > > > > > > > Now would be a good time for someone to feed the whole thing through indent > > > > though. > > > > > > As much as I enjoy using the devfs code as my "bad coding style" > > > example, here's a patch against 2.6.0 that cleans up the devfs code to > > > follow the proper kernel coding style. > > > > I think it needs a little bit more than that Greg. > > Oh, I know it does. That was just a "convert to proper coding format in > 15 minutes" patch. You should start with that and work from there. > But, if you are going to do this, remember to submit in incremental > changes. I suggest this patch go in, as it is just a reformatting, > nothing else. Then you can work from there, changing the actual logic > of the code.
Yup, just whitespace fixes please. I don't think I have the energy for a big cleanup exercise right now, and it's not really appropriate. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |