Messages in this thread | | | Date | Tue, 23 Dec 2003 12:14:49 -0500 | From | Jeff Garzik <> | Subject | Re: [PATCH 2/2][RFC] Add dm-crypt target |
| |
On Tue, Dec 23, 2003 at 05:15:41PM +0000, Joe Thornber wrote: > On Tue, Dec 23, 2003 at 06:01:18PM +0100, Christophe Saout wrote: > > So how does this look? > > <snip> > > > -static struct dm_daemon _kcryptd; > > +static struct dm_daemon kcryptd; > > Please keep the leading underscore, it indicates that it is static > data; a convention that is used throughout dm. hch was ok about it > last time he noticed it, so he can't really complain now ;)
ewwww... The programmer knows what is static data without needing a leading underscore.
This practice is wrong for the same reason that Hungarian notation is wrong :)
Jeff
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |