Messages in this thread | | | Subject | RE: minor e1000 bug | Date | Sun, 21 Dec 2003 21:26:25 -0800 | From | "Feldman, Scott" <> |
| |
> I would also be interested in a statement from intel fellows on the > reasoning behind this decision, since every user of gkrellm will > notice some strange behaviour (value oscillating between 0 and > throughput * 2). (Poor man's real time bandwidth management ;-). > > After being tired of cognitive interpretation of these values, I > decided to fix it, which was pretty easy: > > --- linux-2.4.20/drivers/net/e1000/e1000_main.c~ > 2003-08-03 00:40:21.000000000 +0200 > +++ linux-2.4.20/drivers/net/e1000/e1000_main.c 2003-08-08 > +++ 13:20:06.000000000 +0200 > @@ -1390,7 +1390,7 @@ > netif_stop_queue(netdev); > > /* Reset the timer */ > - mod_timer(&adapter->watchdog_timer, jiffies + 2 * HZ); > + mod_timer(&adapter->watchdog_timer, jiffies + HZ); > }
That should be OK if you're not linked at half duplex or using a 82541/7 Ethernet controller. e1000_smartspeed() and e1000_adaptive_ifs() are sensitive to the watchdog interval, so we'll need to make sure those are OK before adjusting the timer from 2 to 1 seconds. This issue is tracker here: http://bugme.osdl.org/show_bug.cgi?id=1192.
-scott - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |