[lkml]   [2003]   [Dec]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    SubjectRe: [CFT][RFC] HT scheduler

    Rusty Russell wrote:

    >In message <> you write:
    >>+ * See comment for set_cpus_allowed. calling rules are different:
    >>+ * the task's runqueue lock must be held, and __set_cpus_allowed
    >>+ * will return with the runqueue unlocked.
    >Please, never *ever* do this.
    >Locking is probably the hardest thing to get right, and code like this
    >makes it harder.

    Although in this case it is only one lock, and its only used in
    one place, with comments. But yeah its far more complex than a
    blocking semaphore would be.

    >Fortunately, there is a simple solution coming with the hotplug CPU
    >code: we need to hold the cpucontrol semaphore here anyway, against
    >cpus vanishing.
    >Perhaps we should just use that in both places.

    We could just use a private semaphore until the hotplug code is in place.

    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to
    More majordomo info at
    Please read the FAQ at

     \ /
      Last update: 2005-03-22 13:59    [W:0.019 / U:54.540 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site