lkml.org 
[lkml]   [2003]   [Dec]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
From
SubjectLaptop mode and 2.4.23
Date
Using laptop mode for the first time. Kernel is 2.4.23-Vanilla+kdb4.3 on a x86 notebook.

IDE Disk is ext3 mounted with rw,noatime

# cat /proc/sys/vm/laptop_mode
1
# cat /proc/sys/vm/bdflush
30 500 0 0 60000 60000 60 20 0

- Any disk write access spins up and writes as usual after 5 seconds by kjournald
- A disk spinup by kjournald does _not_ run bdflush and kupdated, so once they
elapse, the disk spins up again

This part of the laptop-mode patch is missing and the 5 second interval is still hardcoded:

diff -Nru a/fs/jbd/transaction.c b/fs/jbd/transaction.c
--- a/fs/jbd/transaction.cWed May 14 11:29:52 2003
+++ b/fs/jbd/transaction.cWed May 14 11:29:52 2003
@@ -56,7 +56,11 @@
transaction->t_journal = journal;
transaction->t_state = T_RUNNING;
transaction->t_tid = journal->j_transaction_sequence++;
-transaction->t_expires = jiffies + journal->j_commit_interval;
+/*
+ * have to do it here, otherwise changed age_buffers since boot
+ * wont have any effect
+ */
+transaction->t_expires = jiffies + get_buffer_flushtime();
INIT_LIST_HEAD(&transaction->t_jcb);

IMHO, without this patch, laptop-mode is only half as useful ;)

Why was this part of the patch not used?
Regards
Michael

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 13:59    [W:0.020 / U:2.844 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site