lkml.org 
[lkml]   [2003]   [Dec]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
From
Subject[PATCH] Fix 2.4 EFI RTC oops
Date
This recent change to 2.4:

ChangeSet@1.1069.155.3, 2003-12-10 18:30:50-02:00, trini@mvista.com
[PATCH] Fix rtc leak

===== arch/cris/drivers/ds1302.c 1.6 vs edited =====

broke efirtc.c (it causes a null pointer dereference on ia64).
The fix is below. Please apply.

Bjorn

P.S. The changeset above doesn't appear to be in 2.6 yet. If/when
you submit it for 2.6, you might consider using this style:

memset(&wtime, 0, sizeof(wtime));
memset(wtime, 0, sizeof(*wtime));

which is more obviously correct than:

memset(&wtime, 0, sizeof(struct rtc_time));
memset(wtime, 0, sizeof(struct rtc_time));


===== drivers/char/efirtc.c 1.6 vs edited =====
--- 1.6/drivers/char/efirtc.c Fri Oct 24 04:35:10 2003
+++ edited/drivers/char/efirtc.c Wed Dec 17 14:33:08 2003
@@ -118,7 +118,7 @@
static void
convert_from_efi_time(efi_time_t *eft, struct rtc_time *wtime)
{
- memset(&wtime, 0, sizeof(struct rtc_time));
+ memset(wtime, 0, sizeof(struct rtc_time));
wtime->tm_sec = eft->second;
wtime->tm_min = eft->minute;
wtime->tm_hour = eft->hour;
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 13:59    [W:0.041 / U:0.248 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site