Messages in this thread | | | Date | Sat, 13 Dec 2003 12:54:59 -0200 (BRST) | From | Marcelo Tosatti <> | Subject | Re: [PATCH 2.4] IrDA kernel log buster |
| |
On Thu, 11 Dec 2003, Jean Tourrilhes wrote:
> Hi Marcelo, > > I just ran 2.4.23, and after a few min the disk reached 100% > capacity. A quick check lead to to oversized kernel log, and to the > following changeset : > > http://linux.bkbits.net:8080/linux-2.4/cset@1.1136.23.2?nav=index.html|ChangeSet@-12w > > Patch to fix this problem is attached below, I've just > backported the proper fixes from 2.5.X into 2.4.X. > Probably this person did too much Python, but in C you need > braces around multiple statements part of the same branch, so the > second printf was always executed even when logging was disabled. I > also don't understand why this person didn't decided to backport the > 2.5.X fix. > I'm also bit surprised that this kind of patch went into the > kernel behind my back, because I though that freeze meant not > accepting untested patch from random hacker.
Indeed accepting the patch was a mistake.
Fix applied.
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |