Messages in this thread | | | Date | Sun, 9 Nov 2003 09:27:47 -0800 (PST) | From | Davide Libenzi <> | Subject | Re: [PATCH] Fix find busiest queue 2.6.0-test9 |
| |
On Sun, 9 Nov 2003, Martin J. Bligh wrote:
> +/* > + * macro to make the code more readable - this_rq->prev_cpu_load[i] > + * is our local cached value of i's prev cpu_load. However, putting > + * this_rq->prev_cpu_load into the code makes it read like it's the > + * prev_cpu_load of this_cpu, which makes it confusing to read > + */ > +#define prev_cpu_load_cache(cpu) (this_rq->prev_cpu_load[cpu])
Ouch, the implicit "this_rq" is really evil ;) Eventually:
#define prev_cpu_load_cache(rq, cpu) (rq->prev_cpu_load[cpu])
- Davide
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |