Messages in this thread | | | Date | Sun, 09 Nov 2003 07:58:19 -0800 | From | "Martin J. Bligh" <> | Subject | Re: [PATCH] Fix find busiest queue 2.6.0-test9 |
| |
>> I ran it on the 16-way - no difference in performance. If the code is >> correct as was before (and I agree, it seems it was), perhaps it's just >> in need of a big fat comment to explain the confusion? ;-) > > Ingo already dropped a fat comment ;) This is the relevant part: > > * We fend off statistical fluctuations in runqueue lengths by > * saving the runqueue length during the previous load-balancing > * operation and using the smaller one the current and saved lengths.
I think the confusing bit is this:
this_rq->prev_cpu_load[i] = rq_src->nr_running;
where "this_rq->prev_cpu_load[i]" doesn't intuitively look like what it means ;-) Even just 's/i/cpu/' would help a bit, or something (like wrapping it in macros). Seems it is correct as was though - thanks for explaining it.
M.
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |