Messages in this thread | | | Date | Thu, 27 Nov 2003 19:46:02 +0000 | From | Russell King <> | Subject | Re: [PATCH 2.6]: IPv6: strcpy -> strlcpy |
| |
On Thu, Nov 27, 2003 at 09:09:53PM +0900, YOSHIFUJI Hideaki / ?$B5HF#1QL@?(B wrote: > In article <1069934643.2393.0.camel@teapot.felipe-alfaro.com> (at Thu, 27 Nov 2003 13:04:04 +0100), Felipe Alfaro Solana <felipe_alfaro@linuxmail.org> says: > > > On Thu, 2003-11-27 at 11:59, David S. Miller wrote: > > > > > I agree, using sizeof() is the less error prone way of > > > doing things like this. > > > > > > Felipe could you please rewrite your patch like this? > > > > Done! > > Thanks. Ok to me.
I'm slightly cautious here, although I haven't read the patch yet. Did anyone consider whether any of these structures were copied to user space, and whether, as a result of this change, we're now copying uninitialised data to users?
-- Russell King Linux kernel 2.6 ARM Linux - http://www.arm.linux.org.uk/ maintainer of: 2.6 PCMCIA - http://pcmcia.arm.linux.org.uk/ 2.6 Serial core - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |