Messages in this thread | | | Subject | Re: not fixed in 2.4.23-rc3 (was: Re: 2.4.22 SMP kernel build for hyper threading P4) | From | Len Brown <> | Date | 24 Nov 2003 11:49:18 -0500 |
| |
On Mon, 2003-11-24 at 02:00, William Lee Irwin III wrote:
> A similar (but more elaborate) fix is in 2.6.
Why is the additional variable "kicked" in 2.6 necessary? Appears that kicked == (cpucount + 1), and the loop already compares that to NR_CPUS via max_cpus:
if (max_cpus <= cpucount+1) continue;
Though I think it would read more clearly this way:
if (cpucount + 1 >= max_cpus) break;
Speaking of max_cpus, it would probably be a good thing if maxcpus() did not allow the administrator to set max_cpus > NR_CPUS at boot time.
cheers, -Len
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |