lkml.org 
[lkml]   [2003]   [Nov]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: Fix locking in input
    Pavel Machek writes:

    > input uses "volatile signed char" as a shared variable between normal
    > and interrupt threads (look at _sendbyte()). Thats bad idea, this
    > switches it to atomic_t.

    This change looks unnecessary to me - we aren't trying to increment or
    decrement the variable, just set it and read it. Reading and writing
    individual bytes is atomic on any platform we care about.

    Paul.
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2005-03-22 13:58    [W:0.018 / U:62.492 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site