Messages in this thread | | | Date | Mon, 24 Nov 2003 08:51:16 +1100 | From | Paul Mackerras <> | Subject | Re: Fix locking in input |
| |
Pavel Machek writes:
> input uses "volatile signed char" as a shared variable between normal > and interrupt threads (look at _sendbyte()). Thats bad idea, this > switches it to atomic_t.
This change looks unnecessary to me - we aren't trying to increment or decrement the variable, just set it and read it. Reading and writing individual bytes is atomic on any platform we care about.
Paul. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |