Messages in this thread | | | Date | Thu, 20 Nov 2003 05:49:57 +0000 | From | viro@parcelfa ... | Subject | Re: [PATCH] sysfs_remove_dir Vs dcache_readdir race fix |
| |
On Thu, Nov 20, 2003 at 11:17:07AM +0530, Maneesh Soni wrote: > Hi, > > sysfs_remove_dir modifies d_subdirs list which results in inconsistency > when there is concurrent dcache_readdir is going on. I think there > is no need for sysfs_remove_dir to modify d_subdirs list and removal > of dentries from d_child list is taken care in the final dput().
WTF?
All instances of ->readdir() are protected by ->i_sem on parent. So are all operations in sysfs_remove_dir().
Have you actually observed any race there? - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |