Messages in this thread | | | Date | Sun, 2 Nov 2003 08:25:19 +0100 | From | Willy Tarreau <> | Subject | Re: [patch] reproducible athlon mce fix |
| |
Hi,
I don't know if the patch is correct, but :
On Sun, Nov 02, 2003 at 01:57:48PM +0800, Geoffrey Lee wrote: > preempt_disable(); > +#if CONFIG_MK7 > + for (i=1; i<nr_mce_banks; i++) { > +#else > for (i=0; i<nr_mce_banks; i++) { > +#endif
Including opening braces within #if often fools editors such as emacs which count them and don't know about #if. Then, editing the rest of the file can become annoying because it simply thinks that there are two embedded for loops.
Other solutions to this problem often include one of these constructs which are unfortunately not as beautiful :
1) a still readable one #if CONFIG_MK7 i=1; #else i=0; #endif for (; i<nr_mce_banks; i++) {
2) when there's absolutely no choice (eg changing part of an expression...) something unreadable like this.
for ( #if CONFIG_MK7 i=1; #else i=0; #endif i<nr_mce_banks; i++) {
I'm sure other people have other solution that don't come to mind.
Cheers, Willy
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |