lkml.org 
[lkml]   [2003]   [Nov]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: PATCH: bugfix fü r RadeonFB (against 2.4.22-ac4, bug in 2.6.0-test9, too)
On Wed, 19 Nov 2003, Ronald Lembcke wrote:
> On Wed, Nov 19, 2003 at 10:50:22AM +0100, Geert Uytterhoeven wrote:
> > Your change is not correct: bpp is the _physical_ bits per pixel, i.e. it's 16
> > for both color depth 15 (5/5/5 mode) and color depth 16 (5/6/5).
> >
> > To differentiate between 5/5/5 and 5/6/5, you have to look at green.length, and
> > apply standard fbdev fit-our-round-up[*] rules.
> I don't see where this rule applies here. I searched on google, but
> did't find anything about rounding of color depth.
>
> > Note that some hardware in addition does RGBA4444, too.
> Yes, but that nothing to do with these patches.
>
> Sorry, I don't see, where my patches for intelfb and radonfb (as said
> before, I'm not sure about the imsttfb patch anyway) make the driver
> less correct. Where are they wrong?
>
> Nothing about the use of bits_per_pixel is changed.
> The only change is whether 555 or 565 is default.

Which depends on the color bitmask lengths...

> If those patches are wrong, than matroxfb and rivafb are buggy, too:

Most drivers indeed don't apply the fit-our-round-up rules to the color bitmask
lengths.

My main concern is that while you touch those parts of the code, you should
make it follow the rules instead of doing some ad-hoc changes.

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 13:58    [W:0.333 / U:0.924 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site