Messages in this thread | | | Date | Mon, 17 Nov 2003 21:52:52 -0800 | From | Patrick Mansfield <> | Subject | Re: scsi_report_lun_scan bug? |
| |
On Mon, Nov 17, 2003 at 06:48:33PM -0800, Amit Patel wrote: > Hi, > > I am using 2.6-test9-mm3. I noticed while doing > scsi_report_lun_scan(scsi_scan.c:891) the data > returned is assigned(scsi_scan.c:993) to signed char > array which causes the reported number of luns to be > huge while calculating num_luns to scan. Is there any > particular reason to be data is signed or just a bug? > > I changed it to unsigned char and it seems to work > fine. I have attached a diff of scsi_scan.c. Let me > know if I am missing something.
I don't see why making it signed or unsigned would make any difference.
What values did you see before and after your patch?
It should really be a u8, since it is a pointer to an array of bytes.
(And all the scsi_cmd[]'s should be u8.)
-- Patrick Mansfield - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |