lkml.org 
[lkml]   [2003]   [Nov]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    SubjectRe: invalid SMP mptable on Toshiba Satellite 2430-301
    Date
    Linus Torvalds <torvalds@osdl.org> wrote:
    >
    > On Thu, 13 Nov 2003, Jochen Voss wrote:
    >>
    >> I think the best thing would be, to incorporate the patch to
    >> prevent the crashes with "local APIC support on
    >> uniprocessors" enabled and ignore the rest of the problem.
    >
    > Yup, I'm going to commit a minimal patch that just changes the panic calls
    > into printk's.

    That patch produces a message with no terminating newline on the
    machine in question. This is because one of the four bytes that
    you're printing out is NUL. The following patch avoids that problem.

    Thanks,
    --
    Debian GNU/Linux 3.0 is out! ( http://www.debian.org/ )
    Email: Herbert Xu ~{PmV>HI~} <herbert@gondor.apana.org.au>
    Home Page: http://gondor.apana.org.au/~herbert/
    PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
    --
    --- kernel-source-2.5/arch/i386/kernel/mpparse.c.orig 2003-11-14 19:40:49.000000000 +1100
    +++ kernel-source-2.5/arch/i386/kernel/mpparse.c 2003-11-13 20:48:50.000000000 +1100
    @@ -361,15 +361,12 @@
    unsigned char *mpt=((unsigned char *)mpc)+count;

    if (memcmp(mpc->mpc_signature,MPC_SIGNATURE,4)) {
    - printk("SMP mptable: bad signature [%c%c%c%c]!\n",
    - mpc->mpc_signature[0],
    - mpc->mpc_signature[1],
    - mpc->mpc_signature[2],
    - mpc->mpc_signature[3]);
    + printk(KERN_ERR "SMP mptable: bad signature [0x%x]!\n",
    + *(u32 *)mpc->mpc_signature);
    return 0;
    }
    if (mpf_checksum((unsigned char *)mpc,mpc->mpc_length)) {
    - printk("SMP mptable: checksum error!\n");
    + printk(KERN_ERR "SMP mptable: checksum error!\n");
    return 0;
    }
    if (mpc->mpc_spec!=0x01 && mpc->mpc_spec!=0x04) {
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/
    \
     
     \ /
      Last update: 2005-03-22 13:58    [W:0.042 / U:0.368 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site