lkml.org 
[lkml]   [2003]   [Nov]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: 2.6.0-test9-bk16 ALi M5229 kernel boot error
On Wed, 12 Nov 2003 04:31:34 +0000
viro@parcelfarce.linux.theplanet.co.uk wrote:
> On Tue, Nov 11, 2003 at 07:04:17PM -0800, Linus Torvalds wrote:
>
> > Does this patch fix it?
> > - if (north && north->vendor != PCI_VENDOR_ID_AL) {
> > + if (!isa_dev) {
>
> Wrong fix, AFAICS. Original condition is bogus, no arguments here.
> However, the point is
> "tweak our southbridge only if northbridge is known to be OK with that"
> and not
> "tweak southbridge only if it's ours"
>
> IOW, proper check is || of those two.

I agree with Al's analysis, and this is the kind of logic needed on
sparc64 boxes as well.

Indeed, blindly deref'ing 'isa_dev' here was pretty bogus :)
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 13:58    [from the cache]
©2003-2011 Jasper Spaans