Messages in this thread | | | Subject | Re: [RFC] Smarter stack traces using the frame pointer | From | Andi Kleen <> | Date | Mon, 10 Nov 2003 19:06:03 +0100 |
| |
Adam Litke <agl@us.ibm.com> writes:
> -static int kstack_depth_to_print = 24; > +static int kstack_depth_to_print = 128;
I would not do that. It makes too much of the oops scroll away.
> + show_stack_frame((unsigned long) stack, ebp+4);
I think this needs much more sanity checking, otherwise the risk of recursive oops etc is too big.
I would always check first if the stack value read from ebp is inside the stack page of the current process. If you're paranoid you could even use __get_user() to catch exceptions.
-Andi - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |