Messages in this thread | | | Date | Mon, 6 Oct 2003 21:30:59 -0300 (BRT) | From | Marcelo Tosatti <> | Subject | Re: 2.4.22 ACPI power off via sysrq not working |
| |
On 3 Oct 2003, Andi Kleen wrote:
> Sylvain Pasche <sylvain_pasche@yahoo.fr> writes: > > > Hi, > > > > If I want to halt the system using sys-rq - o key, I get an oops instead > > of a power down. > > Inside pm.c:159, there is: > > > > if (in_interrupt()) > > BUG(); > > > > But if we look at the trace, we are in the interrupt of the keyboard > > handler. > > One fix would be to comment out the BUG line, but there's certainly "a > > better way to do it". > > Use this patch. > > diff -u linux/drivers/acpi/system.c-o linux/drivers/acpi/system.c > --- linux/drivers/acpi/system.c-o 2003-09-07 16:20:44.000000000 +0200 > +++ linux/drivers/acpi/system.c 2003-09-08 21:04:46.000000000 +0200 > @@ -1192,11 +1192,21 @@ > > #if defined(CONFIG_MAGIC_SYSRQ) && defined(CONFIG_PM) > > +static int po_cb_active; > + > +static void acpi_po_tramp(void *x) > +{ > + acpi_power_off(); > +} > + > /* Simple wrapper calling power down function. */ > static void acpi_sysrq_power_off(int key, struct pt_regs *pt_regs, > struct kbd_struct *kbd, struct tty_struct *tty) > -{ > - acpi_power_off(); > +{ > + static struct tq_struct tq = { .routine = acpi_po_tramp }; > + if (po_cb_active++) > + return; > + schedule_task(&tq); > } > > struct sysrq_key_op sysrq_acpi_poweroff_op = {
Fix applied to 2.4 mainline.
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |