lkml.org 
[lkml]   [2003]   [Oct]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [CRYPTO] Testing Module Cleanup.
Hmmm, noticed that I had to fix my mailer. Patch attached properly this
time. Sorry 'bout that.

On 10/06/03 02:41, Erlend Aasland wrote:
>
> --zhXaljGHf11kAtnf
> Content-Type: text/plain; charset=iso-8859-1
> Content-Disposition: inline
>
> Hi Kartikey,
>
> You might want to clean up tcrypt.h a bit with the attached patch. It
> removes more than 700 lines of code :-)
>
> (I have not had a chance to test it yet, I've just checked that it
> compiles. Will test it tomorrow.)
>
> Regards
> Erlend Aasland
>
> On 10/05/03 23:58, kartikey bhatt wrote:
> > done it.
> > sending it as an attachment.
> >
> > -Kartikey Mahendra Bhatt
> >
> > >From: James Morris <jmorris@redhat.com>
> > >To: kartikey bhatt <kartik_me@hotmail.com>
> > >CC: linux-kernel@vger.kernel.org
> > >Subject: Re: [CRYPTO] Testing Module Cleanup.
> > >Date: Thu, 2 Oct 2003 10:35:09 -0400 (EDT)
> > >
> > >On Thu, 2 Oct 2003, kartikey bhatt wrote:
> > >
> > >> sending it as an attachment
> > >>
> > >
> > >I'm seeing a failure with the 5th DES ECB test vector:
> > >
> > > testing des ECB encryption
> > > [...]
> > > test 5 (64 bit key):
> > > 5630092f0161d576
> > > fail
> > >
> > >Could you also retain the weak key test for DES? Just add another field
> > >to the test vector struct to indicate that CRYPTO_TFM_REQ_WEAK_KEY needs
> > >to be set prior to setkey(), then clear it after the test. (Once you do
> > >this the above test vector should fail anyway, which is probably why it
> > >is buggy -- it's never been run).
> > >
> > >Also, a minor nit: please be careful about this kind of thing:
> > >
> > >- * Copyright (c) 2002 Jean-Francois Dive <jef@linuxbe.org>$
> > >+ * Copyright (c) 2002 Jean-Francois Dive <jef@linuxbe.org> ^I$
> > >
> > >
> > >Otherwise, it looks good.
> > >
> > >Thanks,
> > >
> > >
> > >- James
> > >--
> > >James Morris
> > ><jmorris@redhat.com>
> > >
> > >
> > >-
> > >To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> > >the body of a message to majordomo@vger.kernel.org
> > >More majordomo info at http://vger.kernel.org/majordomo-info.html
> > >Please read the FAQ at http://www.tux.org/lkml/
> >
> > _________________________________________________________________
> > Access Hotmail from your mobile now.
> > http://server1.msn.co.in/sp03/mobilesms/ Click here.
\
 
 \ /
  Last update: 2005-03-22 13:49    [W:0.820 / U:0.280 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site