lkml.org 
[lkml]   [2003]   [Oct]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] remove unnecessary #includes from <linux/fs.h>
> You didn't comment on my suggestion, so I've done it manually once for
> linux/fs.h and was shocked. It still passes my compile-standalone
> test after removing 11! #include lines.

A compile-standalone test is a necessary condition but not a sufficient
one. There can be many reasons why the includes might still be needed:
- the compile-test might depend on the specific configuration.
- the included header might be needed when the macros are used, not when
they are defined.
- indirect includes
- ...
As you probably know, I tried to clean up sched.h, and it was extremely
complicated to get right. So this definitely is 2.7 material.

Tim

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 13:49    [W:0.074 / U:0.036 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site