lkml.org 
[lkml]   [2003]   [Oct]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: Linux 2.4 quota (accounting?) bug ...

    Hi,
    > On Sat, Oct 25, 2003 at 06:31:28PM +0200, Jan Kara wrote:
    > > Hi,
    > >
    > > > a friend of mine, made me aware of the following
    > > > imbalance, which looks like a minor accounting bug
    > > > to me, but might be a quota bug ...
    > > Sorry but the code seems correct to me - we get reference to dquot by
    > > get_dquot_ref() and than we put the reference by dqput(). dqput() is
    > > correct because something nasty might happen in the mean time and so we
    > > might be the last holders of the dquot. What do you think is wrong?
    >
    > dqput() does dqstats.drops++;
    > which isn't correct if this should be the same as
    > put_dquot_ref(), but maybe I'm just irritated by
    > strange statistics on some kernels showing more
    > drops than lookups+allocated after sync/quotaoff
    Oh, now I see... At first I didn't understand that the problem is in
    the quota statistics. I'll fix that.

    Honza
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2005-03-22 13:58    [W:4.224 / U:0.244 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site