Messages in this thread | | | Date | Fri, 24 Oct 2003 01:34:53 +0200 | From | Pavel Machek <> | Subject | Re: Kill unneccessary debug printk |
| |
Hi!
> > Actually, that 'printk' is useful. As i understand it, the only way software > > suspend is going to work is that if the same video mode is used on resume as > > on booting. If one uses "vga=ask", then one can 'dmesg | grep' to generate > > a proper string for 'lilo -R' (which i already do to make sure the correct > > kernel gets resumed during testing). If i'm mistaken about needing to set > > VGA mode identically on resume, then i have no objection to removing the > > printk. > > Oops, someone is using my debug printk :-(. I'll at least try > to merge it with some other msg, so it does not waste full > line. > > Better yet, let's take this opportunity to do this more cleanly. How > about having something like /sys/power/vmode (or /proc/...) contain that > inforemation instead? With luck, it might even be few kernel bytes than > the original printk (or at least not much more). (I know nothing about > either /proc or /sys, so it would take me awhile to suggest a patch).
Well, you probably know about as much as I do. I'm afraid I'm just going to take the easy way out. Pavel
-- When do you have a heart between your knees? [Johanka's followup: and *two* hearts?] - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |