lkml.org 
[lkml]   [2003]   [Oct]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: Patch to add support for SGI's IOC4 chipset
Date
On Tuesday 21 of October 2003 08:35, Jeremy Higdon wrote:
> > - defining IDE_ARCH_ACK_INTR and ide_ack_intr() in sgiioc4.c is a no-op,
> > it should be done <asm/ide.h> to make it work
> > (I think the same problem is present in 2.4.x)
>
> The definition in <include/linux/ide.h> is only used if IDE_ARCH_ACK_INTR
> is not defined. sgiioc4.c defines IDE_ARCH_ACK_INTR before including that
> file, so I believe we get the definition we want without touching ide.h,
> don't we?

ide_ack_intr() is used by ide-io.c. If IDE_ARCH_ACK_INTR is not defined
in ide.h (and it won't be cause you are doing this only in sgiioc4.c
/sgiioc4.h in 2.4.x case/ about which ide-io.c has abolutely no idea)
ide_ack_intr() will turn into no-op and hwif->ack_intr() won't be called.

> I'll await a response on the IDE_ARCH_ACK_INTR issue. Do you want me to
> send another patch, or is the previous with your update sufficient?

It is sufficient.

thanks,
--bartlomiej

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 13:58    [W:0.353 / U:0.012 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site