lkml.org 
[lkml]   [2003]   [Oct]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [patch][2/3] qlogic: call request_irq() with private data
On Wed, Oct 15, 2003 at 11:53:49PM -0200, Aristeu Sergio Rozanski Filho wrote:
> + hreg->can_queue = 1;

We already have can_queue set in the host template, so this line is
superflous.

> +#ifdef QL_USE_IRQ
> + if (qlirq < 0 || request_irq(qlirq, do_ql_ihandl, 0, "qlogicfas", hreg))
> + goto free_scsi_host;
> +#endif

Does the driver work at all with QL_USE_IRQ undefined? I don't think so
and if I'm right you should probably nuke the ifdef while you're at it.

> +free_scsi_host:
> + kfree(hreg);

should be

#ifdef PCMCIA
scsi_host_put(shost);
#else
scsi_unregister(shost):
#endif

if the reworked version of the previous patch is applied.

> if (host->can_queue)

can_queue can't be 0 these days so this one could go away aswell.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 13:58    [from the cache]
©2003-2011 Jasper Spaans