lkml.org 
[lkml]   [2003]   [Oct]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [patch][1/3] qlogic: use scsi_host_alloc instead scsi_register
On Wed, Oct 15, 2003 at 11:52:13PM -0200, Aristeu Sergio Rozanski Filho wrote:
> +++ linux/drivers/scsi/qlogicfas.c 2003-10-15 23:41:28.000000000 -0200
> @@ -671,7 +671,7 @@
> if (qlirq >= 0 && !request_irq(qlirq, do_ql_ihandl, 0, "qlogicfas", NULL))
> host->can_queue = 1;
> #endif
> - hreg = scsi_register(host, 0); /* no host data */
> + hreg = scsi_host_alloc(host, 0); /* no host data */
> if (!hreg)
> goto err_release_mem;
> hreg->io_port = qbase;
> @@ -679,6 +679,7 @@
> hreg->dma_channel = -1;
> if (qlirq != -1)
> hreg->irq = qlirq;
> + INIT_LIST_HEAD(&hreg->sht_legacy_list);

This is not good - please use scsi_register for the !PCMCIA case
instead of opencoding it - sht_legacy_list should be completely opaque
to drivers. Maybe once the current freeze is over we can convert
qlogic.c to a proper new-style driver and merge qlogic_cs into it
instead of having two copies of the same codebase compiled with slightly
different cpp symbols.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 13:58    [from the cache]
©2003-2011 Jasper Spaans