lkml.org 
[lkml]   [2003]   [Oct]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
From
SubjectRe: I/O errors in -test7-mm1 tree on ia64
On Thu, Oct 16 2003, Jesse Barnes wrote:
> On Thu, Oct 16, 2003 at 12:49:34PM -0700, William Lee Irwin III wrote:
> > On Thu, Oct 16, 2003 at 11:55:05AM -0700, Jesse Barnes wrote:
> > > I don't see this when using Linus' BK tree as of a few minutes ago, and
> > > the only changes I've made are adding the kgdb.h for ia64 and adding in
> > > the Altix console driver. Any ideas? I'll try reverting some patches
> > > and looking around a bit more.
> >
> > Well, the first thing to try is backing out invalidate_inodes-speedup.patch
>
> That didn't seem to help. Got the same errors.

--- fs/xfs/pagebuf/page_buf.c 2003-10-17 12:11:30.000000000 +0200
+++ fs/xfs/pagebuf/page_buf.c~ 2003-10-17 12:11:19.000000000 +0200
@@ -1406,10 +1406,8 @@
int cmd = WRITE;
if (pb->pb_flags & PBF_READ)
cmd = READ;
-#if 0
else if (pb->pb_flags & PBF_FLUSH)
cmd = WRITESYNC;
-#endif
submit_bio(cmd, bio);
if (size)
goto next_chunk;
it was a mistake to enable barriers unconditionally on XFS when it has
no fallback logic. If you apply the above on test7-mm1, it should work
fine for you.

--
Jens Axboe

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 13:58    [W:2.073 / U:0.600 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site