Messages in this thread | | | Subject | Re: unsafe printk | From | Albert Cahalan <> | Date | 17 Oct 2003 19:52:55 -0400 |
| |
On Fri, 2003-10-17 at 05:52, Pavel Machek wrote: > Hi! > > > Suppose I name an executable this: > > "\n<0>Oops: EIP=0" > > > > That comes out as a KERN_EMERG log message, > > hitting the console and maybe a pager even. > > > > There seem to be a number of places in the > > kernel that printk current->comm without > > concern for what it may contain. > > > > Escape codes and non-ASCII can make for some > > interesting log messages as well. Terminals > > may have some programmable keys or answerback > > messages. So one day root is using grep on > > the log files, and they program the answerback > > string to contain a "\r\nrm -r /\r\n"... > > Or at least you can make his terminal pink ;-). Unfortunately same > problem is with userland programs; root does ps and his terminal goes > pink. Sanitizing kernel messages would be good start, but ps&friends > and ls&friends need to be sanitized, too.
Both ps and ls are protected. At least with the procps-3.1.xx code, w and top are also protected.
So anyway, what to do about the kernel messages? One option is to just mangle comm up front. Another option is to provide a formatting function for safe printing.
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |