Messages in this thread | | | Date | Wed, 15 Oct 2003 21:18:40 +0100 (BST) | From | Hugh Dickins <> | Subject | Re: [PATCH] tmpfs 2/7 LTP S_ISGID dir |
| |
On Wed, 15 Oct 2003 viro@parcelfarce.linux.theplanet.co.uk wrote: > On Wed, Oct 15, 2003 at 08:48:59PM +0100, Hugh Dickins wrote: > > On Wed, 15 Oct 2003 viro@parcelfarce.linux.theplanet.co.uk wrote: > > > On Wed, Oct 15, 2003 at 07:19:46PM +0100, Hugh Dickins wrote: > > > > LTP tests the filesystem on /tmp: many failures when tmpfs because > > > > it missed the way giddy directories hand down their gid. Also fix > > > > ramfs and hugetlbfs. > > > > > > *the* way? I can think of at least two... > > > > You mean, the way they do directories and the way they do non-directories? > > Or, the way they do it if they do it, and the way they do it if they don't? > > Or something else? Please, share your thought! > > "We always inherit parents gid, sgid is ignored" and "we do that only > if parent is sgid and children that happen to be directories inherit > sgid from parent". Yes, ramfs et.al. follow neither of those, but which > way to change that is an interesting question...
The patch chooses the second, which I see as merely fixing an oversight (in the exceptional S_ISGID case); to choose the first convention would be a significant change in behaviour (or a feature request for the option).
Hugh
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |