Messages in this thread | | | Date | Wed, 15 Oct 2003 12:34:55 -0700 | From | Greg KH <> | Subject | Re: [PATCH] pci_get_slot() |
| |
On Wed, Oct 15, 2003 at 07:50:53PM +0100, Matthew Wilcox wrote: > On Wed, Oct 15, 2003 at 11:41:04AM -0700, Greg KH wrote: > > The check of: > > if (dev->bus->number == bus && dev->devfn == devfn) > > in pci_find_slot() doesn't check for the domain? > > No, it would also need to check pci_domain_nr(dev->bus) .. and it doesn't > have anything to check it against as that information isn't passed into > the function.
Ah, missed that. I need to get myself a ppc64 box so I have to worry about the pci domain stuff :)
> > Anyway, is there any other way you can fix this in the tg3 driver only > > for right now? I agree adding the pci function is "cleaner", but a bit > > late for right now. > > The only real way to do it is to inline pci_get_slot() into tg3. Since I > also have a need for it in sym2, that doesn't seem like a sensible idea. > It would also be racy since it wouldn't take the pci_bus_lock.
Ok, fair enough. I'll add it to my tree to be sent to Linus after 2.6.0 is out, if Jeff and David agree it's an ok tg3.c patch.
thanks,
greg k-h - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |