lkml.org 
[lkml]   [2003]   [Oct]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
From
SubjectRe: 2.6.0-test7: saa7134 breaks on gcc 2.95
Eyal Lebedinsky <eyal@eyal.emu.id.au> wrote:
>
> This compiler does not like dangling comma in funcs, so this patch
> is needed. For:
>
> #define dprintk(fmt, arg...) if (core_debug) \
> printk(KERN_DEBUG "%s/core: " fmt, dev->name, ## arg)
>
> Lines like this:
>
> dprintk("hwinit1\n");
>
> should be hacked like this:
>
> dprintk("hwinit1\n", "");

I couldn't find a sane way. Ended up doing this:

diff -puN drivers/media/video/saa7134/saa7134-core.c~saa7134-build-fix drivers/media/video/saa7134/saa7134-core.c
--- 25/drivers/media/video/saa7134/saa7134-core.c~saa7134-build-fix 2003-10-13 22:43:15.000000000 -0700
+++ 25-akpm/drivers/media/video/saa7134/saa7134-core.c 2003-10-13 22:43:15.000000000 -0700
@@ -94,8 +94,13 @@ MODULE_PARM_DESC(latency,"pci latency ti
struct list_head saa7134_devlist;
unsigned int saa7134_devcount;

-#define dprintk(fmt, arg...) if (core_debug) \
- printk(KERN_DEBUG "%s/core: " fmt, dev->name, ## arg)
+#define dprintk(fmt, arg...) \
+ do { \
+ if (core_debug) { \
+ printk(KERN_DEBUG "%s/core: ", dev->name); \
+ printk(fmt, ## arg); \
+ } \
+ } while (0)

/* ------------------------------------------------------------------ */
/* debug help functions */
_

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 13:49    [W:0.039 / U:0.100 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site