lkml.org 
[lkml]   [2003]   [Oct]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] release_region in cciss block driver
Felipe W Damasio <felipewd@terra.com.br> wrote:
>
> --- linux-2.6.0-test6/drivers/block/cciss.c.orig 2003-10-06 10:18:01.000000000 -0300
> +++ linux-2.6.0-test6/drivers/block/cciss.c 2003-10-06 10:25:04.000000000 -0300
> @@ -2185,6 +2185,7 @@
> schedule_timeout(HZ / 10); /* wait 100ms */
> }
> if (scratchpad != CCISS_FIRMWARE_READY) {
> + release_io_mem(c);
> printk(KERN_WARNING "cciss: Board not ready. Timed out.\n");
> return -1;
> }

It seems to me that the driver is already performing this function
in the caller.


static int __devinit cciss_init_one(struct pci_dev *pdev,
const struct pci_device_id *ent)
{
...
if (cciss_pci_init(hba[i], pdev) != 0)
goto clean1;
...
clean1:
release_io_mem(hba[i]);
free_hba(i);
return(-1);
}

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 13:49    [W:0.115 / U:0.096 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site