lkml.org 
[lkml]   [2003]   [Oct]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
From
Subject[pm] fix oops after saving image
Hi!

I was seeing strange oopsen after saving image. They are almost
harmless: anything that happens after writing final signature does not
matter (as long as it does not write to disk). But that oops makes
testing hard as you have to manually powerdown the machine.

free_page() at this point is unneccessary as machine is going down,
anyway. Please apply,
Pavel
PS: For a test, I'm running while true; do echo 4 > /proc/acpi/sleep;
sleep 30; done while making kernel. It seems to work so far.

--- tmp/linux/kernel/power/swsusp.c 2003-10-02 00:04:35.000000000 +0200
+++ linux/kernel/power/swsusp.c 2003-10-01 23:56:49.000000000 +0200
@@ -345,7 +348,7 @@
printk( "|\n" );

MDELAY(1000);
- free_page((unsigned long) buffer);
+ /* Trying to free_page((unsigned long) buffer) here is bad idea, not sure why */
return 0;
}

--
When do you have a heart between your knees?
[Johanka's followup: and *two* hearts?]
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
\
 
 \ /
  Last update: 2005-03-22 13:49    [W:0.061 / U:0.204 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site