lkml.org 
[lkml]   [2003]   [Jan]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] PATCH: IPMI driver
Dave Jones wrote:

>On Thu, Jan 09, 2003 at 01:16:29PM -0600, Corey Minyard wrote:
>
> > >Pull the 2.5 port from openipmi.sourceforge.net saves you doing the port
> > >yourself.
> > >
> > Definately pull the 2.5 port from there, as there are some differences
> > between the 2.4 and 2.5 versions.
>
>I had a quick skim through the patch.
>Is the handling of jiffies wraps done correctly ? It doesn't
>look like it...
>
>time_diff = ((jiffies_now - kcs_info->last_timeout_jiffies)
>
> Dave
>
I don't understand why that wouldn't work. Those are both unsigned long
values. Assuming twos complement, the time difference could be correct,
even in a wraparound case (unless a very large number of jiffies has
transpired, but that will never be the case here).

Am I missing something here?

-Corey


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 13:32    [W:0.042 / U:0.120 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site