[lkml]   [2003]   [Jan]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
Patch in this message
Subjectunix_getname buglet - > 2.5.4(?)
Hi there,

Evolution is non-functioning on recent 2.5.X kernels, due to
mal-performance in getpeername => net/unix/af_unix.c (unix_getname),
where it seems we switch 'sk' on 'peer', but not the (previously)
typecast pointer to it; this fixes it.

--- af_unix.c.old Tue Jan 7 11:59:09 2003
+++ af_unix.c Tue Jan 7 12:00:45 2003
@@ -1097,7 +1097,7 @@
static int unix_getname(struct socket *sock, struct sockaddr *uaddr,
int *uaddr_len, int peer)
struct sock *sk = sock->sk;
- struct unix_sock *u = unix_sk(sk);
+ struct unix_sock *u;
struct sockaddr_un *sunaddr=(struct sockaddr_un *)uaddr;
int err = 0;

@@ -1112,6 +1112,7 @@

+ u = unix_sk(sk);
if (!u->addr) {
sunaddr->sun_family = AF_UNIX;
Thanks Joaquim Fellmann (AFAIR) who chased this down to bitkeeper
changeset Sadly I didn't have time to read the rest of that
changeset to see if the mistake pops up elsewhere as well. Please CC me
with replies, not on linux-kernel.


Michael Meeks.

-- <><, Pseudo Engineer, itinerant idiot

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to
More majordomo info at
Please read the FAQ at

 \ /
  Last update: 2005-03-22 13:32    [W:0.057 / U:1.192 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site